fix: error notification when running onboarding tours #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitanOmar
force-pushed
the
remove-error-when-tour-router-change
branch
2 times, most recently
from
805fa70 to
f362e89
Compare
c0rydoras
requested changes
May 16, 2024
|
i'd also change the commit message to something like: |
MitanOmar
force-pushed
the
remove-error-when-tour-router-change
branch
2 times, most recently
from
b89e022 to
6dce422
Compare
MitanOmar
force-pushed
the
remove-error-when-tour-router-change
branch
2 times, most recently
from
b0ae95a to
c1608e4
Compare
derrabauke
approved these changes
May 23, 2024
c0rydoras
reviewed
May 23, 2024
MitanOmar
force-pushed
the
remove-error-when-tour-router-change
branch
from
830e825 to
ad331e5
Compare
MitanOmar
force-pushed
the
remove-error-when-tour-router-change
branch
from
ad331e5 to
a19bcd1
Compare
c0rydoras
approved these changes
May 23, 2024
derrabauke
reviewed
May 23, 2024
| } catch (error) { | ||
| this.notify.error("unexpected error"); | ||
| } catch { | ||
| /* eslint:disable:no-empty */ |
There was a problem hiding this comment.
Suggested change
| /* eslint:disable:no-empty */ | |
| // eslint-disable-line no-empty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #144