Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django-multiselectfield dependency #25

Closed
hairmare opened this issue Apr 15, 2024 · 3 comments · Fixed by #280
Closed

Remove django-multiselectfield dependency #25

hairmare opened this issue Apr 15, 2024 · 3 comments · Fixed by #280
Assignees
Labels
backend This issue or pull request is backend related dependencies Pull requests that update a dependency file enhancement This issue or pull request discusses non feature changes quality This issue or pull request is quality related

Comments

@hairmare
Copy link
Contributor

hairmare commented Apr 15, 2024

The django-multiselect library is a tad unmaintained and it looks like we can remove it completely given we only really use it for the weekdays feature right now.

We used this workaround:

goinnn/django-multiselectfield#131 (comment)

Look here for more info... the library hasn't been maintained for years at this point.

Originally posted by @hairmare in adfinis/timed-backend#1028 (comment)

@hairmare hairmare added dependencies Pull requests that update a dependency file bug Something isn't working feature This issue or pull request discusses a feature labels Apr 15, 2024
@hairmare hairmare changed the title > [goinnn/django-multiselectfield#131 (comment)](https://github.com/goinnn/django-multiselectfield/issues/131#issuecomment-1368239342) Remove django-multiselectfield dependency Apr 15, 2024
@c0rydoras c0rydoras transferred this issue from adfinis/timed-backend May 13, 2024
@c0rydoras c0rydoras added enhancement This issue or pull request discusses non feature changes backend This issue or pull request is backend related and removed feature This issue or pull request discusses a feature labels May 13, 2024
@c0rydoras c0rydoras added this to timed May 13, 2024
@c0rydoras c0rydoras moved this to 🆕 In Discussion in timed May 13, 2024
@c0rydoras c0rydoras added quality This issue or pull request is quality related RFD Request for discussion and removed bug Something isn't working labels May 13, 2024
@c0rydoras c0rydoras moved this from 🆕 In Discussion to 📋 Backlog in timed May 15, 2024
@c0rydoras c0rydoras removed the RFD Request for discussion label May 15, 2024
@c0rydoras
Copy link
Collaborator

I see two ways to do this:

  • we make it a simple text input and the UX gets worse
  • we copy the code over to timed (its not much) and remove things we don't need

@c0rydoras
Copy link
Collaborator

@hairmare @adfinis/dev-backend What would you recommend?

@hairmare
Copy link
Contributor Author

If the UX in question is deep in Django admin land, then we might want to mock up some screenshots and ask the affected end-users for their input.

Copying the code might be just as viable. My gut feeling is that some refactoring would make it pretty much it's own thing anyway if we remove all the bits we don't use.

IMHO if we really want to improve the UX, then we should start thinking if we can completely replace Django admin in full. I'm not sure there is much reason as to why the contents currently managed in Django admin couldn't be exposed in the Ember frontend as their own feature. If we roadmap that, it would help push the removal case.

My gut feeling is that the weekday feature we found is used so rarely that degrading the UX with a simple text field is totally ok. AFAIK the records have almost no churn and there are really few of them.

@c0rydoras c0rydoras linked a pull request Jun 18, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in timed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This issue or pull request is backend related dependencies Pull requests that update a dependency file enhancement This issue or pull request discusses non feature changes quality This issue or pull request is quality related
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants