refactor(backend): make ruff happy

adfinis · Jul 5, 2024 · fd79cd4 · fd79cd4
1 parent 888b9de
commit fd79cd4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/backend/timed/permissions.py b/backend/timed/permissions.py
@@ -109,13 +109,11 @@ def has_permission(self, request, view):
         if not super().has_permission(request, view):  # pragma: no cover
             return False
 
-        if (
+        return (
             request.user.customer_assignees.filter(is_reviewer=True).exists()
             or request.user.project_assignees.filter(is_reviewer=True).exists()
             or request.user.task_assignees.filter(is_reviewer=True).exists()
-        ):
-            return True
-        return False
+        )
 
     def has_object_permission(self, request, view, obj):
         if not super().has_object_permission(request, view, obj):  # pragma: no cover
@@ -220,13 +218,11 @@ def has_permission(self, request, view):
         if not super().has_permission(request, view):  # pragma: no cover
             return False
 
-        if (
+        return (
             request.user.customer_assignees.filter(is_manager=True).exists()
             or request.user.project_assignees.filter(is_manager=True).exists()
             or request.user.task_assignees.filter(is_manager=True).exists()
-        ):
-            return True
-        return False
+        )
 
     def has_object_permission(self, request, view, obj):
         if not super().has_object_permission(request, view, obj):  # pragma: no cover
@@ -280,13 +276,11 @@ def has_permission(self, request, view):
         if not super().has_permission(request, view):  # pragma: no cover
             return False
 
-        if (
+        return (
             request.user.customer_assignees.filter(is_resource=True).exists()
             or request.user.project_assignees.filter(is_resource=True).exists()
             or request.user.task_assignees.filter(is_resource=True).exists()
-        ):
-            return True
-        return False
+        )
 
     def has_object_permission(self, request, view, obj):
         if not super().has_object_permission(request, view, obj):  # pragma: no cover
@@ -339,6 +333,4 @@ def has_permission(self, request, view):
         if not super().has_permission(request, view):  # pragma: no cover
             return False
 
-        if request.user.customer_assignees.filter(is_customer=True).exists():
-            return True
-        return False
+        return request.user.customer_assignees.filter(is_customer=True).exists()
diff --git a/backend/timed/tracking/factories.py b/backend/timed/tracking/factories.py
@@ -59,7 +59,7 @@ class ActivityFactory(DjangoModelFactory):
     not_billable = False
 
     @lazy_attribute
-    def from_time(self):
+    def from_time(self):  # noqa: F811
         return datetime.time(hour=randint(0, 22), minute=randint(0, 59))
 
     @lazy_attribute