fix(frontend): infinite scroll for analysis page (#200)

fixes #185
adfinis · May 23, 2024 · 40aa5a6 · 40aa5a6
1 parent 8226023
commit 40aa5a6
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 88 deletions.
diff --git a/frontend/app/analysis/index/template.hbs b/frontend/app/analysis/index/template.hbs
@@ -393,19 +393,16 @@
                     </tr>
                   {{/each}}
                   {{#if this._canLoadMore}}
-                    <tr>
-                      <td colspan="11" class="text-center">
-                        <InViewport
-                          @rootSelector="analysis-scrollable-container"
-                          @on-enter-viewport={{perform this.loadNext}}
-                          @on-exit-viewport={{fn
-                            (mut this._shouldLoadMore)
-                            false
-                          }}
-                        >
-                          Loading<span class="loading-dots"><i>.</i><i>.</i><i
-                            >.</i></span>
-                        </InViewport>
+                    <tr
+                      {{in-viewport
+                        onEnter=(perform this.loadNext)
+                        onExit=(fn (mut this._shouldLoadMore) false)
+                        viewportSpy=true
+                      }}
+                    >
+                      <td colspan="12" class="text-center">
+                        Loading<span class="loading-dots"><i>.</i><i>.</i><i
+                          >.</i></span>
                       </td>
                     </tr>
                   {{/if}}

diff --git a/frontend/app/components/in-viewport/component.js b/frontend/app/components/in-viewport/component.js
diff --git a/frontend/app/components/in-viewport/template.hbs b/frontend/app/components/in-viewport/template.hbs
diff --git a/frontend/package.json b/frontend/package.json
@@ -75,6 +75,7 @@
     "ember-decorators": "6.1.1",
     "ember-event-helpers": "^0.1.1",
     "ember-fetch": "8.1.2",
+    "ember-in-viewport": "4.1.0",
     "ember-load-initializers": "2.1.2",
     "ember-math-helpers": "2.18.2",
     "ember-moment": "9.0.1",
@@ -107,6 +108,7 @@
     "eslint-plugin-prettier": "4.2.1",
     "eslint-plugin-qunit": "7.3.4",
     "faker": "4.1.0",
+    "fast-redact": "3.3.0",
     "graphql": "16.8.1",
     "loader.js": "4.7.0",
     "miragejs": "^0.1.48",
@@ -142,8 +144,5 @@
         "marked"
       ]
     }
-  },
-  "dependencies": {
-    "fast-redact": "^3.3.0"
   }
-}
+}
diff --git a/frontend/pnpm-lock.yaml b/frontend/pnpm-lock.yaml
diff --git a/frontend/tests/integration/components/in-viewport/component-test.js b/frontend/tests/integration/components/in-viewport/component-test.js