Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Type annotations #1071

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Type annotations #1071

merged 4 commits into from
Apr 29, 2024

Conversation

c0rydoras
Copy link
Contributor

No description provided.

@c0rydoras c0rydoras self-assigned this Apr 26, 2024
@c0rydoras c0rydoras requested a review from a team as a code owner April 26, 2024 09:44
@c0rydoras c0rydoras linked an issue Apr 26, 2024 that may be closed by this pull request
@c0rydoras c0rydoras force-pushed the type-annotations branch 2 times, most recently from 82bb51e to 1c64877 Compare April 26, 2024 13:34
@c0rydoras c0rydoras requested a review from hairmare April 26, 2024 13:39
timed/reports/views.py Outdated Show resolved Hide resolved
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should not spend too much time adding annotations to existing code. The added value gain is not that great to go over everything and "clean it up" all the way.

It's a good thing when writing new code, and I appreciate you doing it here, but let's not start doing this in all projects ;-)

timed/authentication.py Show resolved Hide resolved
timed/employment/models.py Show resolved Hide resolved
@c0rydoras c0rydoras force-pushed the type-annotations branch 3 times, most recently from 4420bf0 to cd96589 Compare April 29, 2024 08:07
@c0rydoras
Copy link
Contributor Author

@c0rydoras c0rydoras enabled auto-merge (rebase) April 29, 2024 08:23
@c0rydoras c0rydoras merged commit 76f3a32 into adfinis:main Apr 29, 2024
3 checks passed
@c0rydoras c0rydoras deleted the type-annotations branch April 29, 2024 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce type hinting
3 participants