Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop duplicate key name #317

Merged
merged 1 commit into from
Aug 5, 2021
Merged

drop duplicate key name #317

merged 1 commit into from
Aug 5, 2021

Conversation

davidkarlsen
Copy link
Contributor

Description

Fix duplicate key name, which causes problems for: fluxcd/flux2#1522

Issues

N/A

Checklist

  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run -a
  • I documented any high-level concepts I'm introducing in docs/
  • If I updated a dependency tool, or app, this PR contains a short summary of the changes I'm pulling
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@davidkarlsen davidkarlsen requested a review from a team as a code owner August 5, 2021 12:13
@davidkarlsen davidkarlsen requested review from eyenx and vmaillot and removed request for a team August 5, 2021 12:13
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2021
@eyenx
Copy link
Member

eyenx commented Aug 5, 2021

Thank you @davidkarlsen good catch!

@vmaillot vmaillot merged commit 88c29d4 into adfinis:master Aug 5, 2021
@davidkarlsen davidkarlsen deleted the master branch August 4, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaillot vmaillot vmaillot approved these changes

@eyenx eyenx eyenx approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidkarlsen @eyenx @vmaillot