Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): enable email settings without email error handler #576

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix(settings): enable email settings without email error handler #576

merged 1 commit into from
Jan 10, 2023

Conversation

trowik
Copy link
Member

@trowik trowik commented Jan 10, 2023

As mentioned in #575 (comment)

@trowik trowik marked this pull request as ready for review January 10, 2023 09:37
@trowik trowik requested review from anehx and open-dynaMIX January 10, 2023 09:37
anehx
anehx requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick for it to be perfect 👍

document_merge_service/settings.py Show resolved Hide resolved
@trowik trowik force-pushed the fix-error-handling branch from 1469030 to e12480d Compare January 10, 2023 09:51
@trowik trowik merged commit c1f4ea2 into adfinis:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anehx anehx anehx approved these changes

@open-dynaMIX open-dynaMIX Awaiting requested review from open-dynaMIX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trowik @anehx