Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight Event Resource and matching Collection #67

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Feb 12, 2020

Added Weight Event (agreed fields only; more changes could be made).
Edited icarResourceCollection so it no longer inherits from icarResource.

@erwinspeybroeck
Copy link
Collaborator

Andrew, In issue 53 I also saw :
2. Add Operator attribute to capture person responsible for manual weighing. Discussed and accepted at last meeting.
3. Add TimeOffFeed attribute (hours) to capture time between animals moved from pasture or feed access to weighing (time to "empty out", hopefully standardising by reducing gut fill). 0 where animals are weighed in a feed environment. Discussed and accepted at last meeting.

You decided not to add them to the weight event? Or forgot them?

Erwin

@cookeac
Copy link
Collaborator Author

cookeac commented Feb 12, 2020

When I did the first commit into my branch, we hadn't had the meeting and added those attributes which came from the Australian group of organisations (another 20 or so companies).
They have another couple of suggestions which I will pose at the meeting and then make a commit with all those changes.

@erwinspeybroeck erwinspeybroeck merged commit 1d2f2b3 into adewg:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants