Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service-sires API - https://github.com/adewg/ICAR/issues/402 #405

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

erwinspeybroeck
Copy link
Collaborator

erwinspeybroeck and others added 4 commits July 28, 2023 08:25
added service-sires
seems identifier-scheme already existed ;-)
tweaked some swagger comments
corrected operation id
Copy link
Collaborator

@cookeac cookeac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In line with our discussion at the meeting, I'm suggesting a little more documentation so people know that only some fields will be populated.

url-schemes/exampleUrlScheme.json Outdated Show resolved Hide resolved
@cookeac
Copy link
Collaborator

cookeac commented Aug 24, 2023

Resolves #402

@cookeac cookeac merged commit 9a0699d into Develop Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants