-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory transaction resources #385
Conversation
Defines a generalised icarInventoryTransactionResource and its specific versions, icarFeedTransactionResource and icarMedicineTransactionResource. Resolves adewg#369
Remove $id terms
Removed extraneous comma
Andrew, a general remark from my side. |
You're exactly right, and I was aware of this. The only thing I could think was documentation - that if you were using the feed or medicine resource type, the family should be set to a constant value. I'll ask my team if there is any way to use the "default" keyword if the property is already defined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Andrew, I'm sorry but I couldn't finish the review due to missing time.
Inventory transactions are already in the example URL scheme. Adding the medicines ones to the health scheme, and the feed ones to the feed scheme.
Reviewed at previous meetings; merging. |
Defines a generalised icarInventoryTransactionResource and its specific versions, icarFeedTransactionResource and icarMedicineTransactionResource. Resolves #369
Note - update to exampleURLScheme included, but I know that I will need to merge these changes with the changes in #381 before this can be merged.