Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group events to URL Schemes #336

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Add group events to URL Schemes #336

merged 2 commits into from
Oct 20, 2022

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Oct 6, 2022 •
edited
Loading

In registrationURLScheme:

  • Add GET, POST, batch POST for group births, deaths, arrivals, departures

In exampleURLScheme:

  • Add GET for group births, deaths, arrivals, departures, treatments, weights.

Resolves #326
Resolves #323

cookeac and others added 2 commits October 6, 2022 21:49
@cookeac
Add group movement events to registration scheme
ca08080 
Add Group birth, deaths, arrivals, departures GET, POST, and batch POST methods.
@cookeac
Add group movements, treatments, weights to example
7f8730b 
Add group GET methods to exampleURLScheme.json.
@cookeac cookeac changed the base branch from ADE-1 to Develop October 6, 2022 22:55
erwinspeybroeck
erwinspeybroeck approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comments

@cookeac cookeac mentioned this pull request Oct 19, 2022
Merged
AndreasSchultzGEA
AndreasSchultzGEA approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@AndreasSchultzGEA AndreasSchultzGEA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been done a lot of changes. I look through them in detail, but did not test the code-generation.

@cookeac cookeac merged commit c264e68 into adewg:Develop Oct 20, 2022
@cookeac cookeac deleted the group-url-updates branch October 20, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasSchultzGEA AndreasSchultzGEA AndreasSchultzGEA approved these changes

@erwinspeybroeck erwinspeybroeck erwinspeybroeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that exampleURLScheme is complete with resource types for 1.3
3 participants
@cookeac @erwinspeybroeck @AndreasSchultzGEA