Made JoinData spec comparable to the DL draft; tagged JD endpoints with new/existing compared to draft #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert to v3
fixed wrongly named animalMovementsSets
removed old yaml file
There was a problem hiding this comment.
Arjan,
Ik zie/denk dat je :
- Geconverteerd hebt naar Open api 3 - swagger ziet er goed uit
- Resources als jsons hebt gedefinieerd – aparte json files
- Tags hebt aangebracht bij de API operaties (New in draft, New in JD en Existing in Draft)
Heb er eens doorgescand en op eerste zicht (zonder diepgang) lijkt het me goed.
Om te bekijken of de tags kloppen heb ik meer tijd nodig ... (lijkt me het belangrijkste?)
cookeac
pushed a commit
that referenced
this pull request
Dec 4, 2019
Update icarMilkingVisitResource.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.