Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create icarAnimalEventCoreResource #292

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Create icarAnimalEventCoreResource #292

merged 1 commit into from
Apr 21, 2022

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Apr 19, 2022

This PR resolves #290

  • Removes animal property from icarEventCoreResource
  • Creates icarAnimalEventCoreResource which incorporates icarEventCoreResource and adds animal property
  • Changes all event instances to incorporate icarAnimalEventCoreResource instead.

@erwinspeybroeck
Copy link
Collaborator

I agree with this pull request. No remarks.

erwinspeybroeck
erwinspeybroeck approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - no remarks

@cookeac cookeac linked an issue Apr 20, 2022 that may be closed by this pull request
Create icarAnimalEventCoreResource #290
Closed
@AndreasSchultzGEA
Copy link
Collaborator

Why do we need this additional new 'AnimalEventCoreResource' as at the moment, no other file seems to inherit from 'IcarEventCoreResource'.
All other resources seem to be prefixed with 'Icar'. Except for an exception-resource. This new one not.

@cookeac cookeac changed the title Create AnimalEventCoreResource Create icarAnimalEventCoreResource Apr 21, 2022
AndreasSchultzGEA
AndreasSchultzGEA approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@AndreasSchultzGEA AndreasSchultzGEA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more comments

@cookeac cookeac merged commit db5b7a7 into adewg:Develop Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasSchultzGEA AndreasSchultzGEA AndreasSchultzGEA approved these changes

@erwinspeybroeck erwinspeybroeck erwinspeybroeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create icarAnimalEventCoreResource
3 participants
@cookeac @erwinspeybroeck @AndreasSchultzGEA