Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed discriminators #287

Merged
merged 1 commit into from
Apr 7, 2022
Merged

removed discriminators #287

merged 1 commit into from
Apr 7, 2022

Conversation

gra-moore
Copy link
Collaborator

No description provided.

@cookeac
Copy link
Collaborator

cookeac commented Apr 5, 2022

This looks good to me.

  • EventType removed from icarEventCoreResource because ResourceType (from icarResource) will serve effectively.
  • IdentifierType removed from icarIdentifierType because identifiers were not designed to use inheritance - but it could be replaced if it was really necessary.
  • MemberType removed from icarResourceCollection because ResourceType (from icarResource) will serve effectively. Note that having a MemberType is interesting in itself, but as implemented it never actually contained the type of the members, only of the collection.

@cookeac cookeac self-requested a review April 5, 2022 09:24
@cookeac cookeac merged commit 9d916d1 into adewg:Develop Apr 7, 2022
@cookeac cookeac mentioned this pull request May 20, 2022
Closed
@cookeac cookeac linked an issue May 20, 2022 that may be closed by this pull request
Current icarResource Discriminator property doesnt appear valid #278
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookeac cookeac cookeac approved these changes

@alamers alamers Awaiting requested review from alamers

@AlexeyHardCode AlexeyHardCode Awaiting requested review from AlexeyHardCode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current icarResource Discriminator property doesnt appear valid
2 participants
@gra-moore @cookeac