Inheritance changes - icarEventCoreResource, icarIdentifierType #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modelling the event core as a base class so that specific event instances can incorporate these fields by reference using "allOf".
Merge from head to branch
I'm thinking that rather than have an icarAnimalIdentifierType and icarLocationIdentifierType and icarHerdIdentifierType and icarMilkVatIdentifierType and ... maybe we should just have icarIdentifierType as all these will now have a scheme and identity.
Created a generic type for identifiers that comprise and id and scheme. This could replace use of icarAnimalIdentificationType if desired.
Removed - I think this is already removed in the master.
Removed - I think this is already removed in the master.
Corrected typo. Discussed generic vs specific identifiers with Arjan.
Corrected typo in file name
Added missing comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created icarIdentifierType (with scheme and id), and made icarAnimalIdentifierType inherit from it.
Added icarLocationIdentifierType as well.
Created icarEventCoreResource, and made icarMilkingVisitResource inherit from it.
I've run these through a JSON Schema Lint tool (https://jsonschemalint.com/#/version/draft-07/markup/json) which changed formatting slightly, sorry.