Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-218: added types, resources and endpoints for daily-milking-ave… #225

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

AndreasSchultzGEA
Copy link
Collaborator

…rages

@cookeac
Copy link
Collaborator

cookeac commented Jul 15, 2021

This looks good to me @AndreasSchultzGEA. @erwinspeybroeck were you thinking about a different way of doing the time periods for 24 hours and 7 days? Otherwise I think this is good to go.

Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem to set it up this way.
One small remark : what about the tag --> ADE-1.1-milk --> will we change, when releasing, all tags to ADE-1.2?

@erwinspeybroeck erwinspeybroeck merged commit 55660ea into adewg:Develop Jul 16, 2021
@alamers alamers linked an issue Jul 29, 2021 that may be closed by this pull request
@cookeac cookeac linked an issue Aug 12, 2021 that may be closed by this pull request
@cookeac cookeac mentioned this pull request Aug 12, 2021
@AndreasSchultzGEA AndreasSchultzGEA deleted the DailyMilkingAverages branch September 9, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milking-Statistics New values for production purposes - Breeding, SucklerCow
3 participants