-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed API's first version #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 5 feed related endpoints
corrected url for feeds
New resource for Feed
New collection of rations
New collection of feed intake events
New collection of daily feed reports
new collection of feed recommendations
enum specifying the different feed categories
enum specifying the different feed categories
forgot Type in the name ...
create a feed type scheme and identifier
create a resource decribing a feed
feed property type creation
create a scheme and id for feed property
FeedCategory missing Type and is not in the types section, but the enums section
missing comma
test to find an error
added the ../types/
create property identifier
test with documenting the fao.org scheme
other way of documenting the schemes for feed type and feed property
added the fao.org scheme and a list of the feed types included in that scheme
thomasd-gea
reviewed
Dec 3, 2020
thomasd-gea
reviewed
Dec 3, 2020
We might need to check which fields are required on the resources. I marked some of them, but we should recheck. |
replaces DilyFeedReportCollection.json
replaces icarDailyFeedReportResource.json
changed after discussion
added some more units next to kilograms GRM = grams ONZ = ounce PN = pounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about issue https://github.com/adewg/ICAR/issues/93
This is the first version of de feeding API's. There are still some things to be done :