Hotfix: Remove oneOf: allow both courses and treatments #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating this hotfix. When can we expect to have this hotfix version 1.1.1? |
|
@dickerpulli - this week I hope |
|
I'm going to merge this myself so @dickerpulli @thomasd-gea can do some testing of code generation. If this works, we'll bundle into a v1.1.1 release. |
|
Thank you 👍 |
|
I can confirm that the code generation now works (Branch ADE-1-1) |
|
@cookeac When can we expect to have the new tag v1.1.1? |
|
@dickerpulli There now Thomas. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix: Simplify icarTreatmentProgramEventResource.json removing "oneOf".
This should fix an OpenAPI 4.x code gen problem that seems to arise from combining "allOf" and "oneOf".
This allows both courses and treatments to be specified in the same object.
I was going to add a discriminator to (e.g. hasTreatments) but thought there may be cases where a combination was valid, and on the basis that it is easier to add an attribute later than remove one, I have left it out.
Proposed for review and inclusion into ADE-1-1 branch for a hotfix (ADE 1.1.1) as it won't break current code but will enable code generation.
Fixes #158