Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum values naming patter (whitespace, dots) #61

Closed
ahokkonen opened this issue Jan 31, 2020 · 5 comments
Closed

Enum values naming patter (whitespace, dots) #61

ahokkonen opened this issue Jan 31, 2020 · 5 comments
Assignees

Comments

@ahokkonen
Copy link
Contributor

Should enum array values be normalized to follow same naming patter?
Some enums uses whitespace in naming and other not (also some uses dots or other characters):

Example icarReproInseminationType vs icarArrivalReasonType:

InseminationType uses combined names for enum values ("NaturalService", "RunWithBull") and ArrivalReasonType uses names with whitespace ("Internal Transfer", "Sale Return", "Stud Service Return"). Same applies for icarRecommendationType, icarDepartureKindType etc.

I known this is not a big issue, but shoud it still be alligned with common naming convention? :)

@cookeac
Copy link
Collaborator

cookeac commented Feb 2, 2020

I think it should be standardised before we get to version 1.0 :-) and I lean towards combined, CamelCase. What do others think?

@erwinspeybroeck
Copy link
Collaborator

I agree : CamelCase

@ahokkonen
Copy link
Contributor Author

I also agree that combined CC would be the best.

@ahokkonen
Copy link
Contributor Author

I can take this on my task list, if no objections? :)

@cookeac
Copy link
Collaborator

cookeac commented Feb 8, 2020

That would be great, thanks

cookeac added a commit that referenced this issue Feb 10, 2020
Resolves #61: Enum values aligned to follow common pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants