-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum values naming patter (whitespace, dots) #61
Comments
I think it should be standardised before we get to version 1.0 :-) and I lean towards combined, CamelCase. What do others think? |
I agree : CamelCase |
I also agree that combined CC would be the best. |
I can take this on my task list, if no objections? :) |
That would be great, thanks |
cookeac
added a commit
that referenced
this issue
Feb 10, 2020
Resolves #61: Enum values aligned to follow common pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should enum array values be normalized to follow same naming patter?
Some enums uses whitespace in naming and other not (also some uses dots or other characters):
Example icarReproInseminationType vs icarArrivalReasonType:
InseminationType uses combined names for enum values ("NaturalService", "RunWithBull") and ArrivalReasonType uses names with whitespace ("Internal Transfer", "Sale Return", "Stud Service Return"). Same applies for icarRecommendationType, icarDepartureKindType etc.
I known this is not a big issue, but shoud it still be alligned with common naming convention? :)
The text was updated successfully, but these errors were encountered: