-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to make Meta required on IcarEventCoreResource and SourceId on Meta required #366
Comments
We agree - for those of us who are using meta.source and meta.sourceId to keep data and identity synchronised between systems, these fields are very much required. They were not initially required in the specification, so they have not been marked as required to avoid breaking existing implementations but the specification for the POST methods makes it clear these need to be used. |
Meeting 2023-03-09:
|
I have activated the Github Discussions feature for our Repo initially. This is helpful because it lets anyone see more about an announcement or a discussion, but it is not clear to me that people can (for instance) subscribe for notifications on the Announcements channel within the discussions. |
We tested the Discussions feature today, and found that you can either:
A solution is to use a mailing list. We will try this one (subscription form here): https://tinyletter.com/icar-ade |
Added notice to discussion #403 and will notify using the mailing list. |
We reviewed this again as we are approaching the release of ADE 1.4. Proposed approach:
|
Update the descriptions of meta and sourceId to show that they SHOULD be filled, stored, and retained if at all possible. Will be required in future major release. Resolves adewg#366 (sort of)
Update descriptions re meta and sourceId. Resolves #366. Includes feedback from meeting 2023-11-30.
Hello
I would like to discuss whether the meta field on icarEventCoreResource.json should be required and whether the sourceId field on icarMetaDataType.json should be required.
While we have made the decision that all our POST endpoints receives a list of events, we require the ability to reply back on each event individually. The client should then use the sourceId field to match responses with requests, so when realizing this, it is very much required.
Looking forward to hear your thoughts on this.
The text was updated successfully, but these errors were encountered: