Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for icarValidSampleFillingIndicatorType.json #116

Closed
cookeac opened this issue Jun 5, 2020 · 0 comments · Fixed by #117
Closed

Add documentation for icarValidSampleFillingIndicatorType.json #116

cookeac opened this issue Jun 5, 2020 · 0 comments · Fixed by #117
Assignees
@cookeac

Comments

@cookeac
Copy link
Collaborator

cookeac commented Jun 5, 2020

Rather than change this type to a more descriptive enumeration, which would be a breaking change, we propose to document the meaning of the 0, 1, 2 values in the description (internal documentation) field.
This is a short term correction to #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cookeac cookeac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explain icarValidSampleFillingIndicator, fix icarQuarterId cookeac/ICAR
1 participant
@cookeac