-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added riscv fixes #2
base: flatcar-4012
Are you sure you want to change the base?
Conversation
fi | ||
rust_targets="${rust_targets#,}" | ||
echo $rust_targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed anymore
@@ -387,8 +388,8 @@ src_configure() { | |||
enable-warnings = false | |||
[llvm.build-config] | |||
CMAKE_VERBOSE_MAKEFILE = "ON" | |||
CMAKE_C_FLAGS_${cm_btype} = "${CFLAGS}" | |||
CMAKE_CXX_FLAGS_${cm_btype} = "${CXXFLAGS}" | |||
CMAKE_C_FLAGS_${cm_btype} = "-O2 -pipe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these have to stay until rust gets properly built using the portage-stable build file, to avoid these hacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CXXFLAGS and CFLAGS inherit the mtune=generic flag, which is not supported on the cross building for riscv64 arch
@@ -510,6 +511,26 @@ src_configure() { | |||
linker = "${S}/cc.sh" | |||
ar = "aarch64-cros-linux-gnu-ar" | |||
EOF | |||
cat <<- 'EOF' > "${S}/cc-riscv.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sense of a better approach here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two commands were also needed, as the rustc has a hardcoded value to the ar and compiler.
sudo ln -sf /usr/x86_64-pc-linux-gnu/riscv64-cros-linux-gnu/gcc-bin/13/riscv64-cros-linux-gnu-gcc /usr/bin/riscv64-sudo ln -sf /usr/libexec/gcc/riscv64-cros-linux-gnu/ar /usr/bin/riscv64-linux-gnu-ar
@@ -1,3 +1,3 @@ | |||
# Enable optimizations for common x86_64 CPUs | |||
CFLAGS="-O2 -pipe -mtune=generic" | |||
CFLAGS="-O2 -pipe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Current status, when running build_packages:
|
No description provided.