SX: update conditional object invariants #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsanger
approved these changes
Jun 8, 2021
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Previously, we didn't allow conditional objects resulting in no styles, for example:
```
styles({ button: false })
```
This change modifies the invariant constraints to allow such situations and return `undefined`.
mrtnzlml
force-pushed
the
sx_update_conditional_object_invariants
branch
from
b7adb4c
to
ee34984
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we didn't allow conditional objects resulting in no styles, for example:
This change modifies the invariant constraints to allow such situations and return
undefined.