-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some code improvements. #32
base: master
Are you sure you want to change the base?
Conversation
f0bf464
to
b27bade
Compare
b27bade
to
2acd81b
Compare
2acd81b
to
2497c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you used a CLI tool for syntax checking?
I'd like to integrate that kind of checking to the CI/CD process with Travis. Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSX / XCode complains about duplicate symbols.
macOS may define 'ALIGN' with a different meaning if some system headers are included.
2497c8c
to
1874ab5
Compare
Once you're doing this, please also remove Lines 119 to 120 in 8e41694
This command is useless in SSE2 mode (it's only needed to switch from MMX to x87), and it becomes an undefined function when MSVC compiler is used. |
Also Lines 127 to 128 in 8e41694
that translates to 64-bit movq , that is only available in x64 mode. Somehow GCC is able to translate it to several SSE instructions, but that's clearly an extension (MSVC refuses to do that). So the code compiles for Win64 but fails for Win32.
|
Change 'uint512_u' to be a type, not a symbol.
OSX / XCode complains about duplicate symbols.
Rename 'uint512_u' to 'gost34112012_uint512_u' to avoid clashes.
Rename the 'ALIGN' macro to 'GOST3411_ALIGN'.
macOS may define 'ALIGN' with a different meaning if some system
headers are included.
Fix '-Wstringop-truncation'.
Use the unaligned version of '_mm_store_si128'.
This is needed for ix86 architectures, as for some unidentified
reason the memory address may not be 16 bytes aligned properly.
The information from the Intel Intrinsics Guide shows no speed
penalty between using the aligned or the unaligned version of
this function.
Remove trailing whitespace.