Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move contact selector to fragment #326

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

hegocre
Copy link
Collaborator

@hegocre hegocre commented Jun 16, 2021

Fixes part of #318

As a side note, save_menu.xml could also be used for moving save button to appbar on reply editor activity.

@hegocre hegocre changed the title Move contact selector to fragment instead of dialog Move contact selector to fragment Jun 16, 2021
@adeekshith
Copy link
Owner

Very nice 😃! Thank you @hegocre

  • Can we auto save selected contacts without clicking on the save button (may be we need a listener)?

save_menu.xml could also be used for moving save button to appbar on reply editor activity

😊👍

and yayy more Kotlin!!

@hegocre
Copy link
Collaborator Author

hegocre commented Jun 16, 2021

Can we auto save selected contacts without clicking on the save button (may be we need a listener)?

The idea of having to save it manually was to be able to change contacts with the ability to undoing by just going back.
What we can do is every time the users tries to go back and exit the activity, a dialog appears asking whether the user wants to save or discard changes.

@adeekshith
Copy link
Owner

What we can do is every time the users tries to go back and exit the activity, a dialog appears asking whether the user wants to save or discard changes.

Dialog idea sounds good! May be we can merge this now and do the dialog change in another iteration.

Also made a layout change in #327

…-constraint

Fix contacts selector constraint
@adeekshith adeekshith merged commit cc37f6f into main Jun 16, 2021
@adeekshith adeekshith deleted the feature/move-contact-selector-to-fragment branch June 16, 2021 14:30
@hegocre
Copy link
Collaborator Author

hegocre commented Jun 16, 2021

Dialog idea sounds good! May be we can merge this now and do the dialog change in another iteration.

Nice! Maybe add it as a task on #318 so we don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants