Add message reply based on contacts #316
Conversation
|
Looks great! Thank you @hegocre 😃 Screenshots:
|
That's nice!
Let me know if there's something that needs to be changed! |
| @@ -40,6 +39,32 @@ private boolean canReply(StatusBarNotification sbn){ | |||
| canSendReplyNow(sbn); | |||
| } | |||
|
|
|||
| private boolean shouldReply(StatusBarNotification sbn){ | |||
| PreferencesManager prefs = PreferencesManager.getPreferencesInstance(this); | |||
| boolean isGroup = sbn.getNotification().extras.getBoolean("android.isGroupConversation"); | |||
There was a problem hiding this comment.
Everything is good except group detection. This should work ideally but there is an issue where images messages in WhatsApp group are not being tagged with isGroupConversation sometimes (#181).
So there is an extra logic to detect that: src
May be we should move that logic to a separate method and reuse it.
Or I will merge this PR as is this evening and raise another one fixing this.
There was a problem hiding this comment.
I tried using that logic, but didn't manage to do it right, so went the easy way as a temporary fix.
There was a problem hiding this comment.
I've read the issue you mentioned, if we are gonna add a new option to do extra checks in settings, i think this should be changed on the new PR
There was a problem hiding this comment.
No probs 😊
I'll merge this PR in the evening (CST) as is and make that fix before I forget. Great work!! 🙌
Also, as you are already good with Kotlin, feel free to use that in the future (anything is fine though). I am planning to move this project to Kotlin in the near future anyways as it is getting difficult to stick to Java in the Android world.
There was a problem hiding this comment.
I've read the issue you mentioned, if we are gonna add a new option to do extra checks in settings, i think this should be changed on the new PR
Yep, Had to do a hotfix for a previous release. As soon as that is done, will make a PR to fix this group issue.
There was a problem hiding this comment.
No probs blush
I'll merge this PR in the evening (CST) as is and make that fix before I forget. Great work!! raised_hands
Sounds nice
Also, as you are already good with Kotlin, feel free to use that in the future (anything is fine though). I am planning to move this project to Kotlin in the near future anyways as it is getting difficult to stick to Java in the Android world.
Yay!
|
Nice work bro @adeekshith @hegocre 🚀🚀 |
|
I think this is like a whitelist. What about adding also a blacklist feature? |
It has both (screenshot) |
|
Yes, it has both, as @adeekshith commented |
|
When will that be available? |
Hi @OLLI-S |
|
@adeekshith Thank you for the info |
|
Uploaded to Google Play. It warns that users will have to manually update this as this requests a new Contacts permission. Just concerned about it a little I hope it should be okay 😕
|
|
Update received some days ago... |
Implemented the ability to choose which contacts to reply.
This needs testing, but looks like it's working for me.
It's only an initial approach, interface could be changed to something nicer and some code might need to be moved to more appropriate places.