-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for link preload hrefs #142
Conversation
Note, this depends on addyosmani/oust#19. I've updated the |
These tests fail with the current
Seems to be related to nodejs/node#3389 since the data returned from the call to |
I believe this is the issue causing failing tests nodejs/node#6666. Seems from https://github.com/nodejs/node/blob/357f904169c39bbc9c2d8558bbffce2337c83c1b/lib/child_process.js#L153 the buffer is not recognized as the expected encoding. To workaround, I've casted the output from |
@@ -43,7 +43,7 @@ | |||
"meow": "^3.3.0", | |||
"mime-types": "^2.1.6", | |||
"object-assign": "^4.0.1", | |||
"oust": "^0.2.3", | |||
"oust": "git://github.com/akrawchyk/oust", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reset this? oust
0.3.0 is now out with the PR you submitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm wondering if #129 is a better idea. I'm pleased oust
supports preload links, but I noticed inline-critical
automates the preload pattern.
This still might be useful, however, if there are manually added preload links in the HTML that critical
will parse. Perhaps both PR's make sense?
This PR adds support for
rel="preload"
stylesheet links as specified here https://w3c.github.io/preload/.It's useful for implementing the preload pattern with loadCSS.