buffer: runtime deprecation of calling Buffer without new

PR-URL: nodejs#8169 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax · Aug 25, 2016 · f2fe558 · f2fe558
1 parent 379d916
commit f2fe558
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -64,7 +64,17 @@ function alignPool() {
  * much breakage at this time. It's not likely that the Buffer constructors
  * would ever actually be removed.
  **/
+var newBufferWarned = false;
 function Buffer(arg, encodingOrOffset, length) {
+  if (!new.target && !newBufferWarned) {
+    newBufferWarned = true;
+    process.emitWarning(
+      'Using Buffer without `new` will soon stop working. ' +
+      'Use `new Buffer()`, or preferably ' +
+      '`Buffer.from()`, `Buffer.allocUnsafe()` or `Buffer.alloc()` instead.',
+      'DeprecationWarning'
+    );
+  }
   // Common case.
   if (typeof arg === 'number') {
     if (typeof encodingOrOffset === 'string') {

diff --git a/test/parallel/test-buffer-deprecated.js b/test/parallel/test-buffer-deprecated.js
@@ -0,0 +1,17 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+
+const expected =
+  'Using Buffer without `new` will soon stop working. ' +
+  'Use `new Buffer()`, or preferably ' +
+  '`Buffer.from()`, `Buffer.allocUnsafe()` or `Buffer.alloc()` instead.';
+
+process.on('warning', common.mustCall((warning) => {
+  assert.strictEqual(warning.name, 'DeprecationWarning');
+  assert.strictEqual(warning.message, expected,
+                     `unexpected error message: "${warning.message}"`);
+}, 1));
+
+Buffer(1);
+Buffer(1);