report: add missing locks for report_on_fatalerror accessors

Overlooked in 2fa74e3. Refs: nodejs#32207
addaleax · Mar 28, 2020 · 9336772 · 9336772
1 parent cd1db2d
commit 9336772
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/node_report_module.cc b/src/node_report_module.cc
@@ -16,6 +16,7 @@
 
 namespace report {
 using node::Environment;
+using node::Mutex;
 using node::Utf8Value;
 using v8::Boolean;
 using v8::Context;
@@ -129,12 +130,14 @@ static void SetSignal(const FunctionCallbackInfo<Value>& info) {
 }
 
 static void ShouldReportOnFatalError(const FunctionCallbackInfo<Value>& info) {
+  Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
   info.GetReturnValue().Set(
       node::per_process::cli_options->report_on_fatalerror);
 }
 
 static void SetReportOnFatalError(const FunctionCallbackInfo<Value>& info) {
   CHECK(info[0]->IsBoolean());
+  Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
   node::per_process::cli_options->report_on_fatalerror = info[0]->IsTrue();
 }