Fixed incorrect variable passed to extract_metadata #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect variable (url) was previously passed to the `filecontent` parameter of the **extract_metadata** function, which expects HTML code as a string.
This problem was solved by passing the result of the **fetch_url** function (stored in the variable `downloaded`) to **extract_metadata**::
```python
from trafilatura import fetch_url, extract_metadata
downloaded = fetch_url('https://github.blog/2019-03-29-leader-spotlight-erin-spiceland/')
extract_metadata(downloaded)
```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #678 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 21 21
Lines 3486 3486
=======================================
Hits 3430 3430
Misses 56 56 ☔ View full report in Codecov by Sentry. |
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect variable (url) was previously passed to the
filecontentparameter of the extract_metadata function, which expects HTML code as a string.This problem was solved by passing the result of the fetch_url function (stored in the variable
downloaded) to extract_metadata::