Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precision fix: do not use baseline as backup extraction #646

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

adbar
Copy link
Owner

@adbar adbar commented Jul 17, 2024

There is a small decrease in terms of f-score in the benchmark but it does not make sense to risk extracting all text on the page if focus is on precision.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (e2724a5) to head (d660685).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   97.96%   97.93%   -0.03%     
==========================================
  Files          21       21              
  Lines        3492     3494       +2     
==========================================
+ Hits         3421     3422       +1     
- Misses         71       72       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar marked this pull request as ready for review July 18, 2024 12:05
@adbar adbar merged commit 5ca0d20 into master Jul 18, 2024
14 of 15 checks passed
@adbar adbar deleted the fix_precision branch July 18, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant