Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use with_metadata argument as switch #613

Merged
merged 5 commits into from
Jun 7, 2024
Merged

use with_metadata argument as switch #613

merged 5 commits into from
Jun 7, 2024

Conversation

adbar
Copy link
Owner

@adbar adbar commented Jun 3, 2024

No description provided.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (04c2fdf) to head (261c919).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   97.94%   97.77%   -0.18%     
==========================================
  Files          21       21              
  Lines        3501     3499       -2     
==========================================
- Hits         3429     3421       -8     
- Misses         72       78       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar marked this pull request as ready for review June 6, 2024 11:48
@adbar adbar merged commit 2e2022a into master Jun 7, 2024
14 of 15 checks passed
@adbar adbar deleted the with_metadata branch June 7, 2024 14:40
@fortyfourforty
Copy link

It is a breaking change. I lost 30k of title extraction due to this change.
Not to complain, but why make with_metadata=False the default?

For normal users, more data is a good thing as metadata also provides useful information. For advances users, they know how to turn off metadata extraction for speed.

I suggest making the default True. just my 0.2 cents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants