Handle changed behaviour of lxml
addnext
method
#484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the two usages of
addnext
and replaced them byinsert
. The code is maybe a bit harder to read now, but I thought this would be easier than to check thelxml
version or how tails are handled by theaddnext
method.I had to adjust two test cases, since some elements now have whitespace instead of
None
as tail. However, I thought this to be an acceptable change in behaviour.I tested the changes with
lxml==4.9.4
andlxml==5.1.0
and it works with both versions.