Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 and 3.7 #134

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

Dunedan
Copy link
Contributor

@Dunedan Dunedan commented Jun 5, 2024

Python 3.7 is end-of-life for a year now and Python 3.6 even longer, so let's drop support for them to not limit the use of Python language features to one supported by those outdated Python versions.

Python 3.7 is end-of-life for a year now and Python 3.6 even longer, so
let's drop support for them to not limit the use of Python language
features to one supported by those outdated Python versions.
@adbar
Copy link
Owner

adbar commented Jun 5, 2024

Yes I was thinking about it too, I know people with old computers and there are downloads for older Python version but maybe it's just tests. Version 1 is out now and can be used in such cases.

Two suggestions:

  • You can search the code for "3.6"/"3.7" mentions and remove the lines accordingly.
  • Since we're at it we could modernize the setup, I'm thinking about pyproject.toml + setuptools, this would be another PR.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (6860df6) to head (b2d0f70).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   96.38%   97.15%   +0.77%     
==========================================
  Files          33       33              
  Lines         581      563      -18     
==========================================
- Hits          560      547      -13     
+ Misses         21       16       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dunedan
Copy link
Contributor Author

Dunedan commented Jun 6, 2024

Yes I was thinking about it too, I know people with old computers and there are downloads for older Python version but maybe it's just tests. Version 1 is out now and can be used in such cases.

People using old Python version will inevitably have to pick old versions of libraries, as most Python libraries only support still supported Python versions. IMO it's not worth the additional effort to continue to support unsupported Python versions.

  • You can search the code for "3.6"/"3.7" mentions and remove the lines accordingly.

I had done that already and to my knowledge there are no mentions of these Python versions anywhere in the project anymore. What I missed were the conditional imports (if sys.version_info >= (3, 8) …), but I removed those as well now.

  • Since we're at it we could modernize the setup, I'm thinking about pyproject.toml + setuptools, this would be another PR.

Yes, I'd argue as well that this should be a separate PR.

@adbar
Copy link
Owner

adbar commented Jun 6, 2024

The files were what I meant, thanks!

@adbar adbar merged commit 5f4fa16 into adbar:main Jun 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants