Vitest: use browser mode #3222
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,58 +1,41 @@ | ||
| import { act } from 'react'; | ||
| import { commands, userEvent } from '@vitest/browser/context'; | ||
|
|
||
| import type { Column } from '../../src'; | ||
| import { resizeHandleClassname } from '../../src/HeaderCell'; | ||
| import { getGrid, getHeaderCells, setup } from '../utils'; | ||
|
|
||
| interface Row { | ||
| readonly col1: number; | ||
| readonly col2: string; | ||
| } | ||
|
|
||
| interface ResizeArgs { | ||
| readonly column: HTMLElement; | ||
| readonly resizeBy: number; | ||
| } | ||
|
|
||
| async function resize({ column, resizeBy }: ResizeArgs) { | ||
| const resizeHandle = column.querySelector(`.${resizeHandleClassname}`); | ||
| if (resizeHandle === null) return; | ||
|
|
||
| await act(async () => { | ||
| // @ts-expect-error | ||
| await commands.resizeColumn(resizeBy); | ||
| }); | ||
| } | ||
|
|
||
| async function autoResize(column: HTMLElement) { | ||
| const resizeHandle = column.querySelector(`.${resizeHandleClassname}`); | ||
| if (resizeHandle === null) return; | ||
|
|
||
| // eslint-disable-next-line testing-library/no-unnecessary-act | ||
| await act(async () => { | ||
| await userEvent.dblClick(resizeHandle); | ||
| }); | ||
| } | ||
|
|
||
| const columns: readonly Column<Row>[] = [ | ||
| { | ||
| key: 'col1', | ||
| name: 'col1', | ||
|
|
@@ -68,34 +51,85 @@ const columns: readonly Column<never>[] = [ | |
| } | ||
| ]; | ||
|
|
||
| test('should not resize column if resizable is not specified', async () => { | ||
| setup<Row, unknown>({ columns, rows: [] }); | ||
| const [col1] = getHeaderCells(); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| await resize({ column: col1, resizeBy: 50 }); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| await resize({ column: col1, resizeBy: -50 }); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| }); | ||
|
|
||
| test('should resize column when dragging the handle', async () => { | ||
| setup<Row, unknown>({ columns, rows: [] }); | ||
| const [, col2] = getHeaderCells(); | ||
| const grid = getGrid(); | ||
| expect(grid).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| await resize({ column: col2, resizeBy: -50 }); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 150px' }); | ||
| }); | ||
|
|
||
| test('should use the maxWidth if specified', async () => { | ||
| setup<Row, unknown>({ columns, rows: [] }); | ||
| const [, col2] = getHeaderCells(); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px ' }); | ||
| await resize({ column: col2, resizeBy: 1000 }); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 400px' }); | ||
| }); | ||
|
|
||
| test('should use the minWidth if specified', async () => { | ||
| setup<Row, unknown>({ columns, rows: [] }); | ||
| const [, col2] = getHeaderCells(); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| await resize({ column: col2, resizeBy: -150 }); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 100px' }); | ||
| }); | ||
|
|
||
| test('should not auto resize column if resizable is not specified', async () => { | ||
|
There was a problem hiding this comment. Now we can test auto column |
||
| setup<Row, unknown>({ | ||
| columns, | ||
| rows: [ | ||
| { | ||
| col1: 1, | ||
| col2: 'a'.repeat(50) | ||
| } | ||
| ] | ||
| }); | ||
| const [col1] = getHeaderCells(); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| await autoResize(col1); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| }); | ||
|
|
||
| test('should auto resize column when resize handle is double clicked', async () => { | ||
| setup<Row, unknown>({ | ||
| columns, | ||
| rows: [ | ||
| { | ||
| col1: 1, | ||
| col2: 'a'.repeat(50) | ||
| } | ||
| ] | ||
| }); | ||
| const [, col2] = getHeaderCells(); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| await autoResize(col2); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 327.703px' }); | ||
| }); | ||
|
|
||
| test('should use the maxWidth if specified on auto resize', async () => { | ||
|
There was a problem hiding this comment. I will add it in the nest PR |
||
| setup<Row, unknown>({ | ||
| columns, | ||
| rows: [ | ||
| { | ||
| col1: 1, | ||
| col2: 'a'.repeat(500) | ||
| } | ||
| ] | ||
| }); | ||
| const [, col2] = getHeaderCells(); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 200px' }); | ||
| await autoResize(col2); | ||
| expect(getGrid()).toHaveStyle({ gridTemplateColumns: '100px 400px' }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove these checks?
this checked that when typing on a cell, it opens the editor and the editor receives focus, and we continue typing in the editor
this checked that we scrolled back to the cell even if we had scrolled past it (see
await scrollGrid({ scrollTop: 2000 });above)Maybe we need more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to check the actual row in the view instead of spying on
scrollIntoView