Remove filter props #2412
Merged
Remove filter props #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
May 19, 2021
| import faker from 'faker'; | ||
| import { css } from '@linaria/core'; | ||
|
|
||
| import DataGrid from '../../src'; | ||
| import type { Column, Filters } from '../../src'; | ||
| import { NumericFilter } from './components/Filters'; |
There was a problem hiding this comment.
I think NumericFilter is complex and not needed for examples.
| @@ -1,11 +1,10 @@ | |||
| import { useMemo, useState } from 'react'; | |||
| import Select from 'react-select'; | |||
There was a problem hiding this comment.
Removed react-select filter and using datalist instead to keep things simple
There was a problem hiding this comment.
Do we use react-select at all anymore?
There was a problem hiding this comment.
It is used in one of the editors. We can remove it in the next PR
stories/demos/HeaderFilters.tsx
Outdated
| onChange={(e) => | ||
| setFilters({ | ||
| ...filters, | ||
| complete: Number.isFinite(e.target.valueAsNumber) |
There was a problem hiding this comment.
TIL e.target.valueAsNumber
nstepien
requested changes
May 19, 2021
| @@ -1,11 +1,10 @@ | |||
| import { useMemo, useState } from 'react'; | |||
| import Select from 'react-select'; | |||
There was a problem hiding this comment.
Do we use react-select at all anymore?
stories/demos/HeaderFilters.tsx
Outdated
| onChange={(e) => | ||
| setFilters({ | ||
| ...filters, | ||
| complete: Number.isFinite(e.target.valueAsNumber) |
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
nstepien
reviewed
May 19, 2021
Co-authored-by: Nicolas Stepien <[email protected]>
nstepien
requested changes
May 19, 2021
Co-authored-by: Nicolas Stepien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
