-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouping #2106
Merged
Merged
Grouping #2106
Changes from all commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
cd928bc
Initial commit
611ab6f
Merge branch 'canary' into am-group
amanmahajan7 3d6dd33
Group by multiple columns
bc00cbc
Cleanup viewport rows
654ce7f
memoize group row, add groupRowRenderer prop
067f4e6
Cleanup useViewportColumns
5122d29
Merge branch 'canary' into am-group
amanmahajan7 c56e0a1
Merge branch 'canary' into am-group
amanmahajan7 8ed8a15
Merge branch 'canary' into am-group
c5de19e
Fix keys
4f8e333
Add column.groupFormatter prop and checkbox column
d6300f7
Merge branch 'canary' into am-group
93f3a97
Checkbox selection for group row
1d60925
Validate groupBy columns
cd46e74
Ckeck isSelectable
f82ec68
ColSpan
0a89bd8
Merge branch 'canary' into am-group
amanmahajan7 e3ff003
Disable copy/paste and cell drag down on treegrid
8f06cb8
Add treegrid aria attributes
25e2269
Fix rowsCount
2d856dc
Fix rowsCount
4815742
Fix aria-rowindex and aria-rowcount and update grouprow props
3efd6c8
Change expandedGroupIds/onExpandedGroupIdsChange to props
33c23ff
Use 1 loop
bd4c121
Cleanup
cbfd03f
Add GroupCell component
b0df238
Add row selection for group rows
c7b7156
Cleanup
e6954eb
Merge branch 'canary' into am-group
3d94e78
Merge branch 'canary' into am-group
amanmahajan7 6d5ab53
Handle Home and End keys for GroupRow
f0c894d
Clanup navigation logic
e2f9116
Cleanup
2deba45
Improve navigation logic
a63d051
Cleanup
7f5e2da
Merge branch 'canary' into am-group
amanmahajan7 26b2712
Merge branch 'canary' into am-group
45308ab
Merge branch 'canary' into am-group
amanmahajan7 410e248
Handle copy/paste
58beda7
Grouping story
0142a4d
Add select to choose group by field
73a4ce9
Use SortableSelect
0b1c8d2
Cleanup
11c10d0
Improve types
a09c1cf
Merge branch 'canary' into am-group
0b7fd8c
Fic type
984fe09
Address comments
3a2b7a6
Merge branch 'canary' into am-group
amanmahajan7 84c310a
Merge branch 'canary' into am-group
26a33dd
useFocusRef
ed7b131
Update src/DataGrid.tsx
amanmahajan7 49fa7ab
Update src/DataGrid.tsx
amanmahajan7 917a906
Update src/types.ts
amanmahajan7 d19914d
Update src/types.ts
amanmahajan7 1618d8b
Fix types
c53fd7a
Add stopPropagation helper
4ea5d71
Move onExpandedGroupIdsChange check outside
dce4652
Cleanup
44e7da4
Add groupFocusable and remove __isGroup field
db1b1ff
fix dependencies
c94af15
Merge branch 'canary' into am-group
amanmahajan7 66430ea
Fix expandedGroupId
df78487
Fix row navigation
5131f2b
fix border styles
nstepien ea64380
Use a single array
2d14c81
Cleanup groupBy columns logic
5f8aaf5
Link TS issue
40ffbf0
Add icon prop to ToggleGroupedFormatter
07d79ab
Cell drag is not supported on a treegrid
b438c8a
Add caret icon
02d336a
Center align
b9134d5
-moz-middle-with-baseline;
ca9d900
Update changelog
b8cd85b
Update src/utils/columnUtils.ts
amanmahajan7 e6273f6
Address comments
a4cd283
Use the suggested sorting logic
b42a5fe
Do not mutate formatterOptions
5813f4a
Make group cell clickable
fa5ca5f
Mock less files for tests
46d122a
Merge branch 'canary' into am-group
7df2db6
Merge branch 'canary' into am-group
e3dc7a6
Inline getVerticalRangeToRender
426b8c8
Merge branch 'canary' into am-group
amanmahajan7 9e0edfd
Merge branch 'canary' into am-group
amanmahajan7 359e6cf
Update src/DataGrid.tsx
amanmahajan7 0bc28c1
Update src/DataGrid.tsx
amanmahajan7 58f991d
Update src/formatters/ToggleGroupFormatter.tsx
amanmahajan7 40aec7e
Update src/formatters/ToggleGroupFormatter.tsx
amanmahajan7 6d34c54
Revert jest changes
9306ff4
Cleanup parameters
7a15b05
add grouprow.less
85b5e99
Add a comment
bc56dc5
Update src/GroupCell.tsx
amanmahajan7 3173451
Update stories/demos/Grouping.tsx
amanmahajan7 18eb98a
Update stories/demos/Grouping.tsx
amanmahajan7 b41bf6e
Update style/index.less
amanmahajan7 5132d47
Do not extract all the props
d2d1ff0
Do not extract focus and keydown
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendering an empty cell for
groupBy
columns