Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cell navigation Performance #1123

Merged
merged 135 commits into from
May 24, 2018
Merged
Show file tree
Hide file tree
Changes from 133 commits
Commits
Show all changes
135 commits
Select commit Hold shift + click to select a range
1458888
Move cell selection responsibilty to SelectionMask component
malonecj Feb 12, 2018
a59e730
Selection Mask working at 60fps
malonecj Feb 12, 2018
0a426b1
Tests for InteractionMask navigation
malonecj Feb 16, 2018
0cf47d9
Editor Container in interaction Layer
malonecj Feb 16, 2018
c8730c5
Resolve conficts after React 16 catchup
malonecj Feb 19, 2018
1984d07
commit package-lock.json
malonecj Feb 19, 2018
e7ae63c
Editing Working
malonecj Feb 20, 2018
a19d061
smooth scrolling with keyboard navigation
malonecj Feb 28, 2018
13297e1
Adjust visible start/end calculations after scroll
malonecj Feb 28, 2018
cbe087b
Vertical cell Scrolling with keyboard working
malonecj Feb 28, 2018
f68bd47
generic move command
malonecj Mar 1, 2018
42a1b35
Vertical scrolling navigation with keyboard working
malonecj Mar 2, 2018
0a30945
Code cleanup
amanmahajan7 Mar 22, 2018
720e071
Update react to the stable version
amanmahajan7 Mar 22, 2018
98536bd
Remove deprecated babel plugins
amanmahajan7 Mar 22, 2018
0992b49
Export individual constants instead of exporting a default object
amanmahajan7 Mar 22, 2018
c6783a9
Remove react dependency from react-data-grid
amanmahajan7 Mar 22, 2018
2b9b22d
Remove ReactDOM reference and use refs instead
amanmahajan7 Mar 26, 2018
35327e7
More code cleanup
amanmahajan7 Mar 26, 2018
e350a41
Add innerRef to fix scrolling
amanmahajan7 Mar 26, 2018
69f719e
Remove GridWrapper and GridContainer as it breaks instance methods
amanmahajan7 Mar 28, 2018
7ac93b2
Remove unused CellExpander component
amanmahajan7 Mar 28, 2018
05b62e0
- Remove singleton store
amanmahajan7 Apr 2, 2018
89337a0
Delete unused files
amanmahajan7 Apr 2, 2018
c8ed8cb
Move copy paste functionality to the Interaction mask component
amanmahajan7 Apr 5, 2018
38d2c0c
Remove flow types
amanmahajan7 Apr 8, 2018
30c8ddc
Remove flow types
amanmahajan7 Apr 8, 2018
68fa2a8
Remove unused variables
amanmahajan7 Apr 9, 2018
4aebb34
Move copy/paste logic to the interaction layer
amanmahajan7 Apr 9, 2018
07ae30d
Horizontal scroll using keyboard
amanmahajan7 Apr 9, 2018
84e0388
Rename folder to containers
amanmahajan7 Apr 9, 2018
f8ab40f
Fix cell navigation mode
amanmahajan7 Apr 10, 2018
b1bc041
Do not prevent event bubling to show context menu
amanmahajan7 Apr 11, 2018
32b3ff5
Add pointer events to fix cell actions
amanmahajan7 Apr 11, 2018
8983d62
Fix Filter Row focus
amanmahajan7 Apr 11, 2018
ef6393b
Dynamically connect cell to support custom renderers
amanmahajan7 Apr 11, 2018
a9a95b8
Fox committing changes
amanmahajan7 Apr 12, 2018
8c4e9d8
Migrate cell drag down to Interaction Layer
amanmahajan7 Apr 16, 2018
89900f4
Remove react-motion
amanmahajan7 Apr 16, 2018
453e619
Add CellMask to highlight copied cell
amanmahajan7 Apr 16, 2018
31bbe6e
Add drag mask to highlight dragged cells
amanmahajan7 Apr 16, 2018
482b650
Cleanup render method
amanmahajan7 Apr 16, 2018
c9eb9bf
Add eventbus to communicate with InteractionMask component
amanmahajan7 Apr 17, 2018
327ef43
Move EventTypes to contants folder
amanmahajan7 Apr 18, 2018
cb8b3c3
Fix clicking on a cell scrolls the canvas to the top
malonecj Apr 18, 2018
9adffed
Fix cell double click to edit
malonecj Apr 18, 2018
87a6968
Fix tests InteractionMasks
malonecj Apr 18, 2018
4e0851c
Fix issue with press enter not committing
malonecj Apr 18, 2018
1cecaa4
Keep InteractionMask focus logic in central place
malonecj Apr 18, 2018
e57c573
Fix canvas tests
malonecj Apr 18, 2018
9eeb770
Fix Canvas tests
malonecj Apr 18, 2018
01ebd61
Remove redundant Cell tests
malonecj Apr 18, 2018
a8e4f98
Fix Cell tests and remove redundant ones
malonecj Apr 18, 2018
5d27c3a
Fix clicking on a cell scrolls the canvas to the left
amanmahajan7 Apr 18, 2018
d9cab59
Add a new DragEnter method
amanmahajan7 Apr 18, 2018
7078f88
Delete redundant displayStart and displayEnd states
amanmahajan7 Apr 19, 2018
2eb07be
Prevent navigation in FF on drag
amanmahajan7 Apr 19, 2018
d75ade3
Fix Grid.js and remove redundant tests
malonecj Apr 19, 2018
3be42bb
Move tab behaviour from ReactDataGrid to InteractionMask
malonecj Apr 19, 2018
1d6875f
Clean up initial tests for tab behavior in InteractionMasks
malonecj Apr 19, 2018
a400bc9
Fix typo and event name
amanmahajan7 Apr 19, 2018
88a9e09
Use CellNavigationMode constant
amanmahajan7 Apr 19, 2018
00aa182
Ignore invalid drag items
amanmahajan7 Apr 19, 2018
f06c066
Use a single div instead of multiple divs for drag mask
amanmahajan7 Apr 19, 2018
da454d5
Fix SelectionMask zIndex for locked columns
amanmahajan7 Apr 19, 2018
9cf8c33
Delete OverflowCell and OverflowRow components
amanmahajan7 Apr 19, 2018
5a2c3ad
Remove unused props and methods
amanmahajan7 Apr 19, 2018
a8ace7d
Clean up props
amanmahajan7 Apr 19, 2018
8bb0f57
Fix scrolling when scrollToRowIndex is set
amanmahajan7 Apr 19, 2018
de91177
Reorder props for clarity
amanmahajan7 Apr 19, 2018
9312947
Commented unused props and methods
amanmahajan7 Apr 19, 2018
c29dbcd
Fix ESLint errors
amanmahajan7 Apr 19, 2018
ae1ac1b
Dispatch SCROLL_TO_COLUMN event to scroll Canvas from ReactDataGrid
amanmahajan7 Apr 20, 2018
aa60633
Trigger onCellSelected, onCellDeSelected events when cell selection i…
amanmahajan7 Apr 20, 2018
1f0f15b
Fix openCellEditor instance method
amanmahajan7 Apr 20, 2018
e2d5042
Specify required PropTypes
amanmahajan7 Apr 22, 2018
b64ce62
Fix closing tags
amanmahajan7 Apr 22, 2018
53c6a77
Enable auto focus on grid
amanmahajan7 Apr 22, 2018
23b3ba3
Fix last row check
amanmahajan7 Apr 23, 2018
3be3bb5
Implement tab behavior for InteractionMasks
amanmahajan7 Apr 23, 2018
cfa91b7
Resolve conflicts after next catchup
amanmahajan7 Apr 23, 2018
3aa5ede
Fix PropTypes warnings
amanmahajan7 Apr 23, 2018
8c0d6ef
Fix Cell PropTypes
amanmahajan7 Apr 23, 2018
0f76bef
Fix rowData in EditorContainer
amanmahajan7 Apr 24, 2018
87db4fa
Fix null reference error for drag copy
amanmahajan7 Apr 24, 2018
9484813
Check onCheckCellIsEditable for editing
amanmahajan7 Apr 24, 2018
a10a0bc
Fix some broken unit tests
malonecj Apr 24, 2018
36ec992
Removed redundant and fixed remaining tests
malonecj Apr 24, 2018
fd6e8af
Fix context menu
amanmahajan7 Apr 24, 2018
ec6cc52
Fix RowsContainer unit tests
amanmahajan7 Apr 24, 2018
3025b80
Disable duplicate tests
amanmahajan7 Apr 24, 2018
d2a3c54
Fix example home page fonts
malonecj Apr 25, 2018
172ac90
Install latest node version
malonecj Apr 25, 2018
995dc41
Simplify appveyor script after node upgrade
malonecj Apr 25, 2018
1cba4a7
Fix lint errors
malonecj Apr 25, 2018
063d753
Fix failing IE 11 test
malonecj Apr 25, 2018
2574a00
IE compatible version of Array.keys
malonecj Apr 25, 2018
fb5efef
packages/rdg-test-utils/index.js
malonecj Apr 25, 2018
f48b680
Delete unused test-utils project
malonecj Apr 25, 2018
04335a8
install gulp gloablly in order to post to coveralls
malonecj Apr 25, 2018
ee6248e
Use node 6 on appveyor
malonecj Apr 25, 2018
180de95
Delete obsolete scroll utils
amanmahajan7 Apr 25, 2018
dd40693
Add unit tests for CellMask
amanmahajan7 Apr 25, 2018
f7dca67
Add unit tests for CopyMask
amanmahajan7 Apr 25, 2018
c29ea34
Add unit tests for DragMask
amanmahajan7 Apr 25, 2018
9a20a8e
Remove fdescribe
amanmahajan7 Apr 25, 2018
deeed49
Add unit tests for DragHandle
amanmahajan7 Apr 25, 2018
3b30e55
Add unit tests for EventBus
amanmahajan7 Apr 25, 2018
6028f24
Format code and object initialization cleanup
amanmahajan7 Apr 25, 2018
b278553
Add unit test for copy operation
amanmahajan7 Apr 25, 2018
a7ef79e
Use conditional rendering instead of returning null
amanmahajan7 Apr 25, 2018
5cc90aa
Add unit tests for Drag functionaity
amanmahajan7 Apr 25, 2018
8f729ce
Add unit tests for the SelectionMask component
amanmahajan7 Apr 26, 2018
0d6c799
Add unit tests for CanvasUtils
amanmahajan7 Apr 26, 2018
9653bdf
Add unit tests for context menu
amanmahajan7 Apr 26, 2018
78a3bcb
Add test to check if Canvas renders the InteractionMasks component
amanmahajan7 Apr 26, 2018
d5e4d06
Delete commented code
amanmahajan7 Apr 26, 2018
d3ddb6d
Handle scrolling when selected cell hits the top/bottom boundary when…
amanmahajan7 Apr 27, 2018
95b89d2
Fix tab behavior
amanmahajan7 Apr 27, 2018
8a7d842
Fix cell selection mask for grouped rows
malonecj Apr 27, 2018
5830a70
Add back IE support
amanmahajan7 Apr 27, 2018
06c254b
Add polyfills for Set and Map to make the examples work in IE10
amanmahajan7 Apr 27, 2018
418b4dc
Remove unused variable
amanmahajan7 Apr 27, 2018
997d958
Fix zIndex for filters
amanmahajan7 Apr 27, 2018
1834237
Fix scrolling when editor is closed
amanmahajan7 Apr 27, 2018
d135a43
Deleted commented code
amanmahajan7 Apr 27, 2018
5a13dba
Fix eslint errors
amanmahajan7 Apr 27, 2018
525fc81
Delete obsolete tests
amanmahajan7 May 1, 2018
ad16034
Fix Typo
amanmahajan7 May 1, 2018
8d7ed63
Move the drag enter logic to Row component
amanmahajan7 May 1, 2018
2f24e3c
Uncomment code
amanmahajan7 May 1, 2018
18fd79c
Resolve conflicts after next catchup
amanmahajan7 May 12, 2018
24ee795
Fix event bus prop type
amanmahajan7 May 21, 2018
ea7b1f3
Define ref callback as a bound method on the class
amanmahajan7 May 24, 2018
6dd8ace
Remove private getSelectedValue method
amanmahajan7 May 24, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
{
"presets": ["react", "es2015-loose"],
"plugins": [
'transform-class-properties',
'transform-es3-member-expression-literals',
'transform-es3-property-literals'
]
"presets": [
"es2015",
"react",
"stage-2"
],
"plugins": [
"transform-class-properties",
"transform-es3-member-expression-literals",
"transform-es3-property-literals"
]
}
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ dist
npm-debug.log
lerna-debug.log
**.orig
.vscode
.vscode
package-lock.json
4 changes: 2 additions & 2 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ environment:

# Install scripts. (runs after repo cloning)
install:
- ps: Install-Product node 6
# Decrypt .npmrc.enc file for publishing purposes if not pull request build and not scheduled build
# Lerna needs to have a npmrc for each package folder as it does not use the root npmrc https://github.com/lerna/lerna/issues/296#issuecomment-261080345
- ps: >-
Expand All @@ -25,9 +26,8 @@ install:
./ci/publish/copy-npmrc.ps1
}
- set PATH=%APPDATA%\npm;%PATH%
- npm cache clean
- npm install -g gulp
- npm install
- npm install gulp -g
- ps: ./ci/buildScripts/build.ps1

# Post-install test scripts.
Expand Down
7 changes: 5 additions & 2 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"lerna": "2.0.0-beta.34",
"version": "4.0.8"
"lerna": "2.8.0",
"version": "4.0.8",
"packages": [
"packages/*"
]
}
8 changes: 3 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"fs-extra": "^0.30.0",
"keymirror": "^0.1.1",
"object-assign": "^4.1.1",
"prop-types": "^15.5.10",
"prop-types": "^15.6.1",
"react-contextmenu": "^2.9.2",
"react-dnd": "^2.5.4",
"react-dnd-html5-backend": "^2.5.4",
Expand All @@ -46,11 +46,9 @@
"babel-plugin-transform-class-properties": "^6.4.0",
"babel-plugin-transform-es3-member-expression-literals": "^6.5.0",
"babel-plugin-transform-es3-property-literals": "^6.5.0",
"babel-plugin-transform-react-jsx": "^6.4.0",
"babel-plugin-typecheck": "^3.6.1",
"babel-preset-es2015": "^6.9.0",
"babel-preset-es2015-loose": "^7.0.0",
"babel-preset-react": "^6.3.13",
"babel-preset-stage-2": "^6.24.1",
"copy-dir": "^0.3.0",
"css-loader": "^0.26.0",
"del": "^1.2.1",
Expand Down Expand Up @@ -81,7 +79,7 @@
"karma-phantomjs-launcher-nonet": "^0.1.3",
"karma-sourcemap-loader": "^0.3.7",
"karma-webpack": "^1.7.0",
"lerna": "2.0.0-beta.34",
"lerna": "^2.8.0",
"minimist": "^1.1.0",
"mkdirp": "^0.5.1",
"moment": "^2.10.6",
Expand Down
Loading