Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values not showing up for right-hand column cells when resize the window #1087

Closed
8 tasks
francesc79 opened this issue Jan 19, 2018 · 14 comments
Closed
8 tasks
Labels

Comments

@francesc79
Copy link

  • Have you already searched for similar issues? Please help us out and double-check first!

  • Also, please don't be that person who deletes this template. It's here for a reason.

  • Thanks!


Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • [X ] v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • [X ] Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • [X ] 🐛 Bug Report
  • 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md


Issue Details

When I resize the window same column cells disappear. I debug the library and I find what hepped.
Into ViewportScrollMixin module is defined componentWillReceiveProps livecycle hook that call updateScroll function. The problem for my opinion is that when call updateScroll without last parameter width the function getRenderedColumnCount consider this.props.columnMetrics.totalWidth that is not updated.

--

francesc79 pushed a commit to francesc79/react-data-grid that referenced this issue Jan 19, 2018
francesc79 pushed a commit to francesc79/react-data-grid that referenced this issue Jan 23, 2018
francesc79 pushed a commit to francesc79/react-data-grid that referenced this issue Feb 1, 2018
@animeshkayal
Copy link

Facing similar issue while increasing the width of a column and then horizontal scroll to right.

@zyxelvincenzo79
Copy link

i have the same problem

@thupi
Copy link

thupi commented Mar 5, 2018

I have same issue and is currently looking for a table solution :-) Any progress on this :-) ?

@francesc79
Copy link
Author

@thupi I opened a PR, the bug was just fix, I'm waiting the merge with master. If you want try the fix you can checkout francesc79/react-data-grid branch zazos-issue-1087.

@amanmahajan7
Copy link
Contributor

This is a known issue where sometimes the cell content is empty. We are actively working on improving the cell rendering logic and v4 should address this issue. In the meantime re-rendering grid seems like a potential solution

window.addEventListener('resize', () => {
   // Re-render grid
   // May be recalculate grid's minHeight
   const minHeight = ....;
   this.setState({ minHeight });
   // Or may be forceUpdate (not a huge fan of this approach)
   this.forceUpdate();
});

@animeshkayal
Copy link

Hi Aman,
Kindly let us know when can we expect the V4 release?

@rlreamy
Copy link
Contributor

rlreamy commented Jun 1, 2018

Is this fixed in any of the v4 releases?

@kevyu
Copy link

kevyu commented Jun 5, 2018

I think the bug still exists in v4.

@amanmahajan7
Copy link
Contributor

Please check the change log for what is included in v4. We recently merged a PR that improves cell rendering logic and will fix this particular issue. It is a big rewrite and we discovered a few bugs during internal testing. This is being actively worked on but at this moment we do not know when this will be released. I will keep you all posted.

@MickaToast
Copy link

MickaToast commented Jun 17, 2018

Hi, any update on this? Or at least could you bump @next on NPM with the PR you mentioned @amanmahajan7 ? Thanks.

@stale
Copy link

stale bot commented Jul 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 18, 2018
@rlreamy
Copy link
Contributor

rlreamy commented Jul 18, 2018

Is there any update on this? It looks like it was supposed to be fixed in v4.

@stale stale bot removed the wontfix label Jul 18, 2018
@vellov
Copy link

vellov commented Aug 1, 2018

Any update on this?

@stale
Copy link

stale bot commented Aug 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 31, 2018
@stale stale bot closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants