Enable the no-undef rule (#1397)

adazzle · Nov 26, 2018 · cb4fdc4 · cb4fdc4
1 parent 57119fd
commit cb4fdc4
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 16 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -10,9 +10,8 @@
   },
   "globals" : {
     "adz": true,
-    jQuery: true,
-    translate: true,
-    pluralTranslate: true
+    "jQuery": true,
+    "Immutable": true
   },
   "rules": {
 /**
@@ -44,7 +43,8 @@
       "vars": "local",
       "args": "after-used"
     }],
-    "no-use-before-define": 2,       // http://eslint.org/docs/rules/no-use-before-define
+    "no-use-before-define": 2,       // http://eslint.org/docs/rules/no-use-before-define,
+    "no-undef": 2,
 
 /**
  * Possible errors

diff --git a/packages/react-data-grid-addons/src/data/__tests__/Selectors.spec.js b/packages/react-data-grid-addons/src/data/__tests__/Selectors.spec.js
@@ -38,7 +38,7 @@ function executeSpyTests(fn) {
     it('should have filterTerm in every filter object', () => {
       const filters = options.filters;
       for (let i = 0; i < filters.length; i++) {
-        expect(filter.filterTerm).toBeDefined();
+        expect(filters[i].filterTerm).toBeDefined();
       }
     });
   });

diff --git a/packages/react-data-grid-addons/src/editors/widgets/DateRangeFilter.js b/packages/react-data-grid-addons/src/editors/widgets/DateRangeFilter.js
@@ -1,5 +1,7 @@
 const React = require('react');
 import PropTypes from 'prop-types';
+import moment from 'moment';
+
 const ReactDOM = require('react-dom');
 const Moment 		 = require('moment');
 const $					 = require('jquery');
@@ -280,7 +282,8 @@ DateRangePicker.prototype = {
       if ($(this.element).is('input[type=text]')) {
         const val = $(this.element).val();
         const split = val.split(this.separator);
-        start = end = null;
+        let start = null;
+        let end = null;
         if (split.length === 2) {
           start = moment(split[0], this.format);
           end = moment(split[1], this.format);

diff --git a/packages/react-data-grid/src/EmptyChildRow.js b/packages/react-data-grid/src/EmptyChildRow.js
@@ -1,15 +1,9 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import {getSize, getColumn} from './ColumnUtils';
+import { getSize, getColumn, getValue } from './ColumnUtils';
 
 class EmptyChildRow extends React.Component {
-
-  constructor() {
-    super();
-    this.onAddSubRow = this.onAddSubRow.bind(this);
-  }
-
-  onAddSubRow() {
+  onAddSubRow = () => {
     this.props.onAddSubRow(this.props.parentRowId);
   }
 
@@ -39,7 +33,7 @@ class EmptyChildRow extends React.Component {
     };
     const expandColumn = getColumn(this.props.columns.filter(c => c.key === this.props.expandColumnKey), 0);
 
-    const cellLeft = expandColumn ? expandColumn.left  : 0;
+    const cellLeft = expandColumn ? expandColumn.left : 0;
     return (<div className="react-grid-Row rdg-add-child-row-container" style={style}>
       <div className="react-grid-Cell" style={{ position: 'absolute', height: cellHeight, width: '100%', left: cellLeft }}>
         <div className="rdg-empty-child-row" style={{ marginLeft: '30px', lineHeight: `${cellHeight}px` }}>

diff --git a/packages/react-data-grid/src/__tests__/ColumnMetrics.spec.js b/packages/react-data-grid/src/__tests__/ColumnMetrics.spec.js
@@ -1,3 +1,4 @@
+import Immutable from 'immutable';
 import getScrollbarSize from '../getScrollbarSize';
 const ColumnMetrics = require('../ColumnMetrics');
 

diff --git a/packages/react-data-grid/src/__tests__/Header.spec.js b/packages/react-data-grid/src/__tests__/Header.spec.js
@@ -1,4 +1,6 @@
 import React from 'react';
+import Immutable from 'immutable';
+
 import Header from '../Header';
 import HeaderRow from '../HeaderRow';
 import helpers, {fakeCellMetaData} from '../helpers/test/GridPropHelpers';

diff --git a/packages/react-data-grid/src/masks/InteractionMasks.js b/packages/react-data-grid/src/masks/InteractionMasks.js
@@ -299,7 +299,7 @@ class InteractionMasks extends React.Component {
     if (isFunction(onCellCopyPaste)) {
       onCellCopyPaste({
         cellKey,
-        rowIdx,
+        rowIdx: toRow,
         fromRow,
         toRow,
         value: textToCopy