Reintroduce old TmpFileSegmentWriteOutMedium #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Have it as a legacy option
imply-cheddar
force-pushed
the
keep-legacy-write-out-bytes
branch
from
07d738d
to
ef20cbc
Compare
adarshsanjeev
approved these changes
Aug 7, 2024
adarshsanjeev
merged commit c80aede
into
adarshsanjeev:write-out-bytes-improvement
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce old TmpFileSegmentWriteOutMedium
We make it a legacy option and give it a new name. It exists solely to give us something to roll back to in case the new logic causes problems that didn't previously exist. We should update the release notes to also indicate that this is being done and tell people to set the properties for the legacyTmpFile in case they have something that with memory usage and SegmentWriteOutMedium that breaks when upgrading.