Chore: Added drawer extension e2e tests (Issue/3470)

[lemmyadams]

addresses adaptlearning/adapt-contrib-resources#111

[cahirodoherty-learningpool]

👀

[oliverfoster]

Interesting... very interesting...

The tests can be run against a specified build output folder, which wouldn't have a src/course but an {outputdir}/{coursedir}/ instead. So we're going to need some way of grabbing that stuff in the test runtime such that the json can be loaded from the correct place.

[oliverfoster]

adapt_framework/grunt/helpers.js

Lines 150 to 152 in 0da0411

	sourcedir: 'src/',
	outputdir: 'build/',
	coursedir: 'course',

adapt_framework/grunt/helpers.js

Lines 201 to 218 in 0da0411

	const outputdir = appendSlash(grunt.option('outputdir')) || exports.defaults.outputdir;
	const cachepath = grunt.option('cachepath') || null;
	const tempdir = outputdir + '.temp/';
	const jsonext = grunt.option('jsonext') || exports.defaults.jsonext;
	const coursedir = grunt.option('coursedir') || adaptJSON.coursedir || exports.defaults.coursedir;
	let languageFolders = '';
	if (grunt.option('languages') && grunt.option('languages').split(',').length > 1) {
	languageFolders = '{' + grunt.option('languages') + '}';
	} else {
	languageFolders = grunt.option('languages');
	}
	// Selectively load the course.json ('outputdir' passed by server-build)
	const configDir = grunt.option('outputdir') ? outputdir : sourcedir;
	// add root path if necessary, and point to course/config.json
	const configPath = path.join(path.resolve(root, configDir), coursedir, 'config.' + jsonext);

adapt_framework/test.js

Lines 69 to 72 in 0da0411

	'node',
	'./node_modules/grunt/bin/grunt',
	'diff',
	shouldUseOutputDir && `--outputdir=${outputDir}`

[cahirodoherty-learningpool]

Cheers Oli
I understand wanting to account for configurable paths, but the default of the framework build is to the directories stated so we should be okay with these assumptions when it comes to the GHA PR testing
Or did you have something further in mind?

[oliverfoster]

A few people have mentioned they'd like to perform tests based upon the course content, effectively removing some Quality Assurance tasks. We should start from facilitating that point of view, even if we never get there. As the first test, this already relies on the defined course data but will currently fail if used on a course in say, an AAT environment, which specifies outputdir.

[oliverfoster]

The adapt-contrib-resources specific e2e tests should live in resources.

[joe-allen-89]

New data loading needs to be implemented.

[cahirodoherty-learningpool]

Replaced with adaptlearning/adapt-contrib-boxMenu#168 and adaptlearning/adapt-contrib-resources#112