Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: allow for generic feedback text #2408

Closed
moloko opened this issue Apr 8, 2019 · 3 comments
Closed

feature request: allow for generic feedback text #2408

moloko opened this issue Apr 8, 2019 · 3 comments

Comments

@moloko
Copy link
Contributor

moloko commented Apr 8, 2019

A lot of the time I see question feedback in Adapt that's along the lines of:

"_feedback": {
    "correct": "That's correct. This is some additional text explaining why the answer is what it is.",
    "_incorrect": {
        "final": "Your answer was incorrect. This is some additional text explaining why the answer is what it is."
    },
    "_partlyCorrect": {
        "final": "Your answer was partly correct. This is some additional text explaining why the answer is what it is."
    }
}

To that end, I wonder if we could save content authors (and translators) a fair bit of time and effort by allowing for something like this:

"_feedback": {
    "generic": "This is some additional text explaining why the answer is what it is.",
    "correct": "That's correct. {{{generic}}}",
    "_incorrect": {
        "final": "Your answer was incorrect. {{{generic}}}"
    },
    "_partlyCorrect": {
        "final": "Your answer was partly correct. {{{generic}}}"
    }
}
@oliverfoster
Copy link
Member

oliverfoster commented Apr 8, 2019

there's a large discussion on how _feedback is insufficient if you could have a look as see if it's worth pulling it into this discussion?

#1469
@amruta-thakur has a really nice idea of removing feedback from the core in its entirety

@chucklorenz
Copy link
Member

If I understand your approach, authors could choose not to use {{{generic}}} and to continue to write as current. That would be helpful, I think, for implementation in the AAT--because it wouldn't have to be implemented. For the course authors I support who use the AAT, the variations of feedback cause ongoing confusion. I'd prefer not to increase that with another option--unless it can be done in the AAT with some "elegance". But I see plenty of room for this as a shortcut for FW authors.

@chucklorenz
Copy link
Member

Another minor suggestion. To me "generic" sounds like another category of feedback alongside "correct" and "incorrect". Perhaps we avoid that bit of confusion by using a word/phrase that hints at it being an included part, something along the lines of "repeatedText" or "common".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants