Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tutor #1469

Closed
oliverfoster opened this issue Mar 15, 2017 · 1 comment · Fixed by adaptlearning/adapt-contrib-tutor#61
Closed

Extend tutor #1469

oliverfoster opened this issue Mar 15, 2017 · 1 comment · Fixed by adaptlearning/adapt-contrib-tutor#61
Assignees

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Mar 15, 2017

Pull in some other tutor types to expand the extension offering

types:

  • notify default, notify popup
  • overlay sits over the component
  • inline sits after the component

example json:

"_tutor": {
    "_type": "inline"
},
"_feedback": {
    "correct": "Correct text",
    "incorrect": "Incorrect text"
}
@amruta-thakur
Copy link

Hi @oliverfoster -
Below are the 4 bullet suggestions or questions on above comment:

  • Can we give this changeable titles in "_feedback" object? Such as:
"_feedback":{
    "correct": "Correct text",
    "incorrect": "Incorrect text",
    "buttonTitle": "Continue"
}
  • What do this means feedback you can't dismiss? Does the feedback is always visible? Or is it like you have suggested in inline feedback?

  • Graphics, video can also be added in "_feedback" object. This one I have already done in my local framework,
    For Example:

"_feedback":{
    "correct": "Correct text",
    "incorrect": "Incorrect text",
    "buttonTitle": "Continue",
    "graphics": {
         "src":"course/en/images/small.jpg", // This will include path for any image,file, or video
         "alt":"no image"
   }
}
  • Moving feedback text to the tutor means we have to move all the functionality for feedback in questionView to the tutor. In this case I would suggest we will just trigger the custom event from questionView as soon as answer have been submitted and tutor will listen to this event and all the checking for correct, incorrect and partly correct answer will be done in tutor and will send the appropriate feedback to the notify as well. This is just my opinion, may be we have to make more huddle for the same because we need to change functionality in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants