Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted to stable Mongoose version #2704

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Reverted to stable Mongoose version #2704

merged 2 commits into from
Aug 14, 2023

Conversation

simondate
Copy link
Member

@simondate simondate commented May 14, 2023

Fixes #2697 by reintroducing former stable version of connect-mongodb-session, mongoose and mongodb, which have support for domainsEnabled property.

#### Fixing domainsEnabled issue in Adapt Authoring
If you are getting following error in console
```
(node:23152) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead. (Triggered by calling processImmediate on process.)
(Use `node --trace-deprecation ...` to show where the warning was created)
```
Then follow the steps mentioned below:
Steps:
1. Application.js
	1. Modify connection options with domainsEnabled for connect-mongodb-session
	2. Instead of requestDomain.enter use requestDomain.run(next) and comment next()
2. permissions.js inside policyChecker function
	1. Line 497, update to
		1. const user = app.usermanager.getCurrentUser() || JSON.parse(JSON.stringify(req.session.passport.user));
3. Manually install
	1. npm i [email protected]
	2. npm i [email protected]
Copy link
Member Author

@simondate simondate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chetan has shown these changes as working on a call with me.

@taylortom taylortom changed the base branch from master to release/0.11.2 May 19, 2023 15:04
@taylortom taylortom added this to the v0.11.2 milestone May 19, 2023
@simondate
Copy link
Member Author

👍 Since I created I can't +1 but doing it here

Copy link
Member

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@taylortom taylortom merged commit 57eda53 into release/0.11.2 Aug 14, 2023
@taylortom taylortom deleted the issue/2697 branch August 14, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imported course doesn't set correct ownership
3 participants