Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return early if target attribute already exists #2440

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Return early if target attribute already exists #2440

merged 3 commits into from
Oct 18, 2019

Conversation

tomgreenfield
Copy link
Contributor

Fixes #2433.

See here for the more useful diff sans whitespace changes.

@tomgreenfield tomgreenfield assigned taylortom and unassigned taylortom Oct 14, 2019
@canstudios-nicolaw canstudios-nicolaw added this to the Bug patch milestone Oct 15, 2019
taylortom
taylortom approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@tomgreenfield tomgreenfield merged commit b5edc5c into release/bugpatch Oct 18, 2019
@tomgreenfield tomgreenfield deleted the issue/2433 branch October 18, 2019 15:53
@oscarsiles oscarsiles mentioned this pull request Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancgray dancgray dancgray approved these changes

@taylortom taylortom taylortom approved these changes

@canstudios-nicolaw canstudios-nicolaw Awaiting requested review from canstudios-nicolaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bug patch
Development

Successfully merging this pull request may close these issues.
4 participants
@tomgreenfield @taylortom @dancgray @canstudios-nicolaw