Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading of asset type from schema #2417

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Fix reading of asset type from schema #2417

merged 1 commit into from
Oct 1, 2019

Conversation

tomgreenfield
Copy link
Contributor

Resolves #2416.

@tomgreenfield
Fix reading of asset type from schema
0602be7 
Retain backwards compatibility
canstudios-nicolaw
canstudios-nicolaw approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@canstudios-nicolaw canstudios-nicolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@tomgreenfield tomgreenfield changed the base branch from master to release/bugpatch September 10, 2019 09:55
dancgray
dancgray approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@dancgray dancgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 only

@tomgreenfield tomgreenfield merged commit 725807f into release/bugpatch Oct 1, 2019
@tomgreenfield tomgreenfield deleted the issue/2416 branch October 1, 2019 13:58
@cksachdev cksachdev mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canstudios-nicolaw canstudios-nicolaw canstudios-nicolaw approved these changes

@dancgray dancgray dancgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bug patch
Development

Successfully merging this pull request may close these issues.
3 participants
@tomgreenfield @dancgray @canstudios-nicolaw