Fix preset dropdown always defaulting to 'no preset' #2401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2379
In https://github.com/adaptlearning/adapt_authoring/pull/2371/files in plugins/content/config/index.js the following was removed
and replaced with
return next(null, [records[0]]);
This missing .toObject led to the following change 33600c3#diff-6cb64d73a547a24bfc001f80bb7192dc
These two things meant that the _themePreset value was no longer being saved. Fixing these things allows the last selected preset to be saved successfully which fixes this issue.
To test
Select a theme
Select a preset
Save
Open theme editing page, theme and preset should be selected
Change theme
Return to original theme, preset should be selected