Performance improvements #2371
Merged
Performance improvements #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canstudios-nicolaw
added
the
S: awaiting-review
dancgray
approved these changes
Jul 1, 2019
canstudios-matth
approved these changes
Jul 1, 2019
canstudios-nicolaw
removed
the
S: awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2370
On every AT editor page load the config is retrieved
In plugins/content/config/index.js there was some code which did the following on every config load:
The enabledComponents list is not required when navigating around the editor, so this code has been moved into a place in the outputmanger where it is used by preview/export/publish only
Changes have been made to the moved code to make it more efficient, instead of retrieving every component in the course it just retrieves a list of types (eg. text, mcq)
QA have tested this internally