log DB-connection error #2047
Closed
log DB-connection error #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he error message.
taylortom
reviewed
Aug 15, 2018
| @@ -417,6 +417,9 @@ function configureMasterTenant(callback) { | |||
| installHelpers.showSpinner('Starting server'); | |||
| // run the app | |||
| app.run({ skipVersionCheck: true }); | |||
| app.on('serverStartError', function(error) { | |||
| return exit(1, error.message || error); | |||
| }); | |||
There was a problem hiding this comment.
It looks like this just replicates the error handling in lib/application.js
There was a problem hiding this comment.
It also logs the error message that connection failed.
Without that I don't get this message.
|
Is this still needed in regards to #2059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #880
Unfortunately we can only use
lib/databaseonce the app is started (preload the configuration module). Therefore we can't check potential connection issues earlier in the install script.This PR emit's an error event when the app can't be started. This is mostly related to not being able to connect to the DB. The install script displays this error message to the user.
This makes the overall installation experience a bit better, as it gives useful information about what caused the error.